Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for wedrix/watchtower-bundle v2 #1563

Closed
wants to merge 3 commits into from
Closed

Add recipe for wedrix/watchtower-bundle v2 #1563

wants to merge 3 commits into from

Conversation

Wedrix
Copy link
Contributor

@Wedrix Wedrix commented Nov 11, 2023

Copy link

github-actions bot commented Nov 11, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1563/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1563/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'wedrix/watchtower-bundle:^2.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

wedrix/watchtower-bundle

1.0 vs 2.0
diff --git a/wedrix/watchtower-bundle/1.0/config/packages/wedrix_watchtower_bundle.yaml b/wedrix/watchtower-bundle/2.0/config/packages/wedrix_watchtower_bundle.yaml
index e2312b70..85c3d19d 100644
--- a/wedrix/watchtower-bundle/1.0/config/packages/wedrix_watchtower_bundle.yaml
+++ b/wedrix/watchtower-bundle/2.0/config/packages/wedrix_watchtower_bundle.yaml
@@ -3,8 +3,8 @@ wedrix_watchtower:
     schema_file: '%kernel.project_dir%/config/watchtower/schema.graphql'
     plugins_directory: '%kernel.project_dir%/config/watchtower/plugins'
     scalar_type_definitions_directory: '%kernel.project_dir%/config/watchtower/scalar_type_definitions'
-    schema_cache_directory: '%kernel.project_dir%/var/cache/watchtower/schema'
-    cache_schema: false
+    cache_directory: '%kernel.project_dir%/var/cache/watchtower'
+    optimize: false
     debug: true
     context:
         # Register services here to access them in the context param.
@@ -14,5 +14,5 @@ wedrix_watchtower:
 
 when@prod:
     wedrix_watchtower:
-        cache_schema: true
+        optimize: true
         debug: false
diff --git a/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/authorizors/.gitignore b/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/authorizors/.gitignore
deleted file mode 100644
index e69de29b..00000000
diff --git a/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/filters/.gitignore b/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/filters/.gitignore
deleted file mode 100644
index e69de29b..00000000
diff --git a/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/mutations/.gitignore b/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/mutations/.gitignore
deleted file mode 100644
index e69de29b..00000000
diff --git a/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/orderings/.gitignore b/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/orderings/.gitignore
deleted file mode 100644
index e69de29b..00000000
diff --git a/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/resolvers/.gitignore b/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/resolvers/.gitignore
deleted file mode 100644
index e69de29b..00000000
diff --git a/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/selectors/.gitignore b/wedrix/watchtower-bundle/1.0/config/watchtower/plugins/selectors/.gitignore
deleted file mode 100644
index e69de29b..00000000
diff --git a/wedrix/watchtower-bundle/1.0/config/watchtower/scalar_type_definitions/.gitignore b/wedrix/watchtower-bundle/1.0/config/watchtower/scalar_type_definitions/.gitignore
deleted file mode 100644
index e69de29b..00000000

@Wedrix Wedrix changed the title Upgrade to watchtower v2 Add recipe for wedrix/watchtower-bundle v2 Nov 11, 2023
auto-merge was automatically disabled November 11, 2023 04:06

Head branch was pushed to by a user without write access

auto-merge was automatically disabled November 13, 2023 15:28

Head branch was pushed to by a user without write access

@Wedrix
Copy link
Contributor Author

Wedrix commented Nov 15, 2023

Reconsidering design. Closing for now.

@Wedrix Wedrix closed this Nov 15, 2023
auto-merge was automatically disabled November 15, 2023 23:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant